Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix WPT URL tests that fetch JSON data #37624

Closed
wants to merge 1 commit into from
Closed

test: fix WPT URL tests that fetch JSON data #37624

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 6, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 6, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36509/

@targos
Copy link
Member Author

targos commented Mar 8, 2021

Failed without intl:

12:01:35     [UNEXPECTED_FAILURE][FAIL] Parsing: <http://ExAmPlE.CoM> against <http://other.com/>
12:01:35     assert_equals: href expected "http://example.com/" but got "http://ExAmPlE.CoM/"
12:01:35         at Test.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/url/url-constructor.any.js:21:7)
12:01:35         at Test.step (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/testharness.js:2092:25)
12:01:35         at test (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/testharness.js:566:30)
12:01:35         at runURLTests (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/url/url-constructor.any.js:12:5)
12:01:35     Command: /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/node  /home/iojs/build/workspace/node-test-commit-linux-containered/test/wpt/test-url.js url-constructor.any.js

I added small-icu requirement to url-constructor.any.js

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36538/

@targos targos force-pushed the fix-wpt-url-tests branch 2 times, most recently from 5295032 to 6183089 Compare March 8, 2021 18:28
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36544/

@targos
Copy link
Member Author

targos commented Mar 8, 2021

Missed that url-origin.any.js had the same issue.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36548/

targos added a commit that referenced this pull request Mar 9, 2021
@targos
test: fix WPT URL tests that fetch JSON data
52ca115 
PR-URL: #37624
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos
Copy link
Member Author

targos commented Mar 9, 2021

Landed in 52ca115

@targos targos closed this Mar 9, 2021
@targos targos deleted the fix-wpt-url-tests branch March 9, 2021 07:22
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@targos @danielleadams
test: fix WPT URL tests that fetch JSON data
cc48816 
PR-URL: #37624
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @Trott @cjihrig @aduh95